Fix backup download link — missing file= query parameter#970
Merged
Conversation
The download link was generated as /admin/backups/?filename.zip
but the download handler checks $_GET['file'], so the handler
was never triggered. The browser navigated to the page instead
of downloading the file, causing a JS error.
Changed: url('admin/backups') . '/?' . $entry
To: url('admin/backups') . '?file=' . $entry
JulianPrieber
pushed a commit
that referenced
this pull request
Jun 8, 2026
The download link was generated as /admin/backups/?filename.zip
but the download handler checks $_GET['file'], so the handler
was never triggered. The browser navigated to the page instead
of downloading the file, causing a JS error.
Changed: url('admin/backups') . '/?' . $entry
To: url('admin/backups') . '?file=' . $entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Backup files cannot be downloaded from the admin panel. Clicking a backup download button navigates the browser to the page URL instead of triggering a file download, and throws a JS error:
```
Uncaught TypeError: Cannot read properties of null (reading 'addEventListener')
```
Root Cause
The download link is generated with the filename as a bare query key:
```php
// Generates: /admin/backups/?filename.zip
url('admin/backups') . '/?' . $entry
```
But the download handler checks `$_GET['file']`:
```php
if (isset($_GET['file'])) {
$filename = $_GET['file'];
// ... serve file
}
```
Since `$_GET['file']` is never set, the handler is skipped and the page renders as HTML, causing the JS error.
Fix
```php
// Generates: /admin/backups?file=filename.zip
url('admin/backups') . '?file=' . $entry
```
Two corrections in one:
Test
Verified on a self-hosted instance behind an nginx reverse proxy — backup downloads work correctly after this change.